fix(collector): fix dns collector limited to 63 chars #1690
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DexterYan
force-pushed
the
dx/sc-115977/fix-dns-collector-limit
branch
from
4924334 to
7c1ec40
Compare
xavpaice
requested changes
Nov 19, 2024
pkg/collect/host_network_test.go
Outdated
| @@ -44,8 +44,13 @@ func Test_isValidLoadBalancerAddress(t *testing.T) { | |||
| want: false, | |||
| }, | |||
| { | |||
| name: "Too many characters", | |||
| name: "Too many characters less than 255", | |||
There was a problem hiding this comment.
what is this testing for? The name needs to be really clear.
There was a problem hiding this comment.
good catch. I have updated those test names
pkg/collect/host_network_test.go
Outdated
| want: true, | ||
| }, | ||
| { | ||
| name: "Too many characters bigger than 255", |
There was a problem hiding this comment.
let's name this something more clear for what we're testing
xavpaice
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
sc-115977
Checklist
Does this PR introduce a breaking change?